Horton

Re: relation OID in ReorderBufferToastReplace error message

Jeremy Schneider <schnjere@amazon.com>

View thread View on postgr.es
From: Jeremy Schneider <schnjere@amazon.com>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2021-09-23T18:19:39Z
Lists: pgsql-hackers 
On 9/22/21 20:11, Amit Kapila wrote:
> 
> On Thu, Sep 23, 2021 at 3:06 AM Jeremy Schneider <schnjere@amazon.com> wrote:
>>
>> Any chance of back-patching this?
> 
> Normally, we don't back-patch code improvements unless they fix some
> bug or avoid future back-patch efforts. So, I am not inclined to
> back-patch this but if others also feel strongly about this then we
> can consider it.

The original thread about the logical replication bugs spawned a few
different threads and code changes. The other code changes coming out of
those threads were all back-patched, but I guess I can see arguments
both ways on this one.

https://www.postgresql.org/message-id/flat/E1i74JE-00024V-9J%40gemulon.postgresql.org

https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=29b5905470285bf730f6fe7cc5ddb3513d0e6945

https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=df3640e5293dccbf964508babfc067282ea7a2fc


-- 
Jeremy Schneider
Database Engineer
Amazon Web Services

Commits

  1. Back-patch "Add parent table name in an error in reorderbuffer.c."

  2. Add parent table name in an error in reorderbuffer.c.

  3. Fix reorder buffer memory accounting for toast changes.

  4. Add logical change details to logical replication worker errcontext.

  5. Fix toast rewrites in logical decoding.

  6. Add error codes to some corruption log messages