Re: C11 / VS 2019

Peter Eisentraut <peter@eisentraut.org>

From: Peter Eisentraut <peter@eisentraut.org>
To: Tom Lane <tgl@sss.pgh.pa.us>, Nazir Bilal Yavuz <byavuz81@gmail.com>
Cc: Andrew Dunstan <andrew@dunslane.net>, Michael Paquier <michael@paquier.xyz>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2025-07-07T15:08:27Z
Lists: pgsql-hackers
On 07.07.25 16:13, Tom Lane wrote:
> Nazir Bilal Yavuz <byavuz81@gmail.com> writes:
>> On Mon, 7 Jul 2025 at 13:51, Peter Eisentraut <peter@eisentraut.org> wrote:
>>> Hmm.  We have the (allegedly) same VS version in Cirrus CI, and it's
>>> never shown a problem like this.
> 
>> CI uses the latest VS 2019 (v16.11.48), it looks like buildfarm member
>> drongo uses VS 2019 v16.3.1. I created a custom Windows VM with the
>> same VS 2019 version (v16.3.1) at the drongo and CI failed with the
>> same error [1].
> 
> Huh.  Can we trawl the release notes for VS and see if this was
> acknowledged as a bug fix, and if so when did it happen?  I think
> whether we can say "get a newer compiler" depends in part on how
> long it's been fixed.

I tried doing that now, but didn't find anything fitting.

But this one [0] seems to indicate you might need at least 16.5 for this.

Also, there is the support timeline [1] that shows that anything older 
than 16.11.* is way out of support.

[0]: 
https://learn.microsoft.com/en-us/cpp/preprocessor/preprocessor-experimental-overview?view=msvc-170

[1]: 
https://learn.microsoft.com/en-us/visualstudio/releases/2019/servicing-vs2019




Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →
  1. Raise C requirement to C11

  2. meson: Move C99 test earlier

  3. Enable MSVC conforming preprocessor

  4. Make parseNodeString() C idiom compatible with Visual Studio 2015.