Re: [PATCH] Check that index can return in get_actual_variable_range()

Maxime Schoemans <maxime.schoemans@enterprisedb.com>

From: Maxime Schoemans <maxime.schoemans@enterprisedb.com>

To: Peter Eisentraut <peter@eisentraut.org>

Cc: Aleksander Alekseev <aleksander@tigerdata.com>, pgsql-hackers@lists.postgresql.org, Mark Dilger <mark.dilger@enterprisedb.com>

Date: 2025-10-28T13:28:30Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Check that index can return in get_actual_variable_range()
- 74197bdc842a 18.1 landed
- 35e53b68418a 19 (unreleased) landed
Fix crash/valgrind error
- ee1ae8b99f96 18.0 cited
Support non-btree indexes in get_actual_variable_range()
- 9ef1851685b7 18.0 cited

> On 28 Oct 2025, at 10:20, Peter Eisentraut <peter@eisentraut.org> wrote:
> 
> I have committed the first patch.

Great, thank you for looking at this.

> The test suite is probably a bit too bulky for testing this particular niche behavior.  Also, it doesn't work with assertions enabled because of the hardcoded BTREE_AM_OID in src/include/access/nbtree.h.  So I don't plan to commit that.  But it's good to have it in the archive, and perhaps it can be part of a larger test suite for the index AM API at some point in the future.


And I agree, the test suite is probably overkill for this two-line patch, but it might be good to have around for later.