Horton
Menu

Re: Question about InvalidatePossiblyObsoleteSlot()

suyu.cmj <mengjuan.cmj@alibaba-inc.com>

View thread
From: "suyu.cmj" <mengjuan.cmj@alibaba-inc.com>
To: "bertranddrouvot.pg" <bertranddrouvot.pg@gmail.com>
Cc: "bharath.rupireddyforpostgres" <bharath.rupireddyforpostgres@gmail.com>, "amit.kapila16" <amit.kapila16@gmail.com>, "michael" <michael@paquier.xyz>, "pgsql-hackers" <pgsql-hackers@postgresql.org>
Date: 2025-10-13T15:03:02Z
Lists: pgsql-hackers 
Hi,
Thanks for your detailed reply.
> I think that we could get rid of the initial_restart_lsn and just use
> s->data.restart_lsn here (while keeping initial xmin ones to preserve the
> intent of 818fefd8fd4 for those).
I agree with your proposed change.
> Your concern is only about the restart_lsn, right? (asking because I don't think
> it's safe not to rely on the initial_* for the xmin ones, see [1]).
My primary concern is indeed the restart_lsn issue, and thanks again for the clear explanation.
Best regards,
suyu.cmj

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Fix regression with slot invalidation checks

  2. Fix race leading to incorrect conflict cause in InvalidatePossiblyObsoleteSlot()