Horton

Re: 64-bit queryId?

Joshua D. Drake <jd@commandprompt.com>

View thread View on postgr.es
From: "Joshua D. Drake" <jd@commandprompt.com>
To: Robert Haas <robertmhaas@gmail.com>, Greg Stark <stark@mit.edu>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Alexander Korotkov <a.korotkov@postgrespro.ru>, Peter Geoghegan <pg@bowt.ie>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Date: 2017-10-02T15:02:48Z
Lists: pgsql-hackers 
On 10/01/2017 04:22 PM, Robert Haas wrote:
> On Sun, Oct 1, 2017 at 3:48 PM, Greg Stark <stark@mit.edu> wrote:
>> Well these kinds of monitoring systems tend to be used by operations
>> people who are a lot more practical and a lot less worried about
>> theoretical concerns like that.
> 
> +1, well said.
> 
>> In context the point was merely that the default
>> pg_stat_statements.max of 5000 isn't sufficient to argue that 32-bit
>> values are enough. It wouldn't be hard for there to be 64k different
>> queries over time and across all the databases in a fleet and at that
>> point it becomes likely there'll be a 32-bit collision.
> 
> Yeah.
> 
> I think Alexander Korotkov's points are quite good, too.
> 

+1 to both of these as well.

jD

-- 
Command Prompt, Inc. || http://the.postgres.company/ || @cmdpromptinc

PostgreSQL Centered full stack support, consulting and development.
Advocate: @amplifypostgres || Learn: https://pgconf.us
*****     Unless otherwise stated, opinions are my own.   *****

Commits

  1. pg_stat_statements: Add a comment about the dangers of padding bytes.

  2. pg_stat_statements: Widen query IDs from 32 bits to 64 bits.