Horton

Re: partitioning and identity column

Alexander Law <exclusion@gmail.com>

View thread View on postgr.es
From: Alexander Lakhin <exclusion@gmail.com>
To: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
Cc: Peter Eisentraut <peter@eisentraut.org>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2024-02-19T15:00:00Z
Lists: pgsql-hackers 
Hello Ashutosh,

19.02.2024 15:17, Ashutosh Bapat wrote:
>
>> Functions ATExecAddIdentity() and ATExecDropIdentity() are recursive too,
>> so I think they can be exploited as well.
> not just Identity related functions, but many other functions in
> tablecmds.c have that problem as I mentioned earlier.
>

Could you please name functions, which you suspect, for me to recheck them?
Perhaps we should consider fixing all of such functions, in light of
b0f7dd915 and d57b7cc33...

Best regards,
Alexander

Commits

  1. Fix assorted bugs related to identity column in partitioned tables

  2. Remove extra check_stack_depth() from dropconstraint_internal()

  3. Support identity columns in partitioned tables

  4. doc: Add Identity Column section under Data Definition chapter

  5. Assert that partition inherits from only one parent in MergeAttributes()

  6. doc: Decorate PostgreSQL with productname tag

  7. Fix prologue of get_partition_ancestors()