Horton

Re: pg_rewind fails on Windows where tablespaces are used

Andrew Dunstan <andrew@dunslane.net>

View thread
From: Andrew Dunstan <andrew@dunslane.net>
To: Thomas Munro <thomas.munro@gmail.com>, Michael Paquier <michael@paquier.xyz>
Cc: Alexandra Wang <alexandra.wang.oss@gmail.com>, Chris Travers <chris.travers@stormatics.tech>, Farooq Rashed <farooq.rashed@desc.gov.ae>, pgsql-bugs@lists.postgresql.org
Date: 2025-01-08T14:45:19Z
Lists: pgsql-bugs

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Fix readlink() for non-PostgreSQL junction points on Windows.

  2. Fix stat() for recursive junction points on Windows.

  3. Fix pg_rewind with in-place tablespaces when source is remote

  4. Make unlink() work for junction points on Windows.

  5. Use in-place tablespaces in regression test.

On 2024-11-27 We 7:52 AM, Andrew Dunstan wrote:
>
> On 2024-11-26 Tu 8:58 PM, Thomas Munro wrote:
>> It might be worth checking if 4517358e and f71007fb should be
>> back-patched too.  There was a brief discussion[1], but no one with
>> Windows-testing capabilities was around and it didn't seem too
>> serious, and then there was the whole re-wrap and it seemed best to
>> keep out of the way of that.  But now that the coast is clear...
>>
>> [1] 
>> https://www.postgresql.org/message-id/CAD5tBcKnE3C1hycBYZYtYpNssQR_e%2Bu2%3DCmDhGRFvDMEg3onRg%40mail.gmail.com
>
>
>
> Yes, it's on my TODO list. Have been waiting for a) the releases to 
> settle down b) getting availability of Windows resources again and c) 
> being back at my home location. All three are now met, so will work on 
> it.
>
>
>

Those patches didn't actually include any tests. I guess the best test 
would be to create a chain of several junction points and then run 
initdb on the leaf of the chain?


cheers


andrew


--
Andrew Dunstan
EDB: https://www.enterprisedb.com