Thread

Re: Fix out-of-date comment on makeRangeConstructors

Peter Eisentraut <peter@eisentraut.org> — 2025-12-13T15:57:36Z

On 05.12.25 03:26, Chao Li wrote:
>> On Dec 5, 2025, at 06:34, Paul A Jungwirth <pj@illuminatedcomputing.com> wrote:
>> I noticed that makeRangeConstructors (in commands/typecmds.c) says:
>>
>>> We actually define 4 functions, with 0 through 3 arguments.
>>
>> But that hasn't been true since 2011 (df73584431). We only have 2-arg
>> and 3-arg functions. Here is a quick patch to update the comment.
> 
> I think the fix is reasonable, which reflects to the current code:
> 
> ```
> static const char *const prosrc[2] = {"range_constructor2",
> "range_constructor3"};
> static const int pronargs[2] = {2, 3};
> ```

committed