Re: Improve error messages for database object stats manipulation functions during recovery

On 25/10/2024 20:07, Fujii Masao wrote:
> Hi,
> 
> When database object stats manipulation functions like 
> pg_set_relation_stats() are run,
> they currently produce the following error and hint messages, which are 
> "internal"
> and make it hard for users to understand the issue:
> 
>        ERROR:  cannot acquire lock mode ShareUpdateExclusiveLock on 
> database objects while recovery is in progress
>        HINT:  Only RowExclusiveLock or less can be acquired on database 
> objects during recovery.
> 
> So I'd like to propose updating these to clearer messages:
> 
>        ERROR:  recovery is in progress
>        HINT:  Database object statistics manipulation functions cannot 
> be executed during recovery.
> 
> Thought?

Makes sense.

"Database object statistics manipulation functions" is a bit of a 
mouthful". Maybe something like "statistics cannot be modified during 
recovery".

> I've attached a patch implementing these changes. It also updates the 
> documentation to
> clearly state that these functions are not available during recovery.

Looks good to me.

-- 
Heikki Linnakangas
Neon (https://neon.tech)