Horton

Re: Add support for automatically updating Unicode derived files

Peter Eisentraut <peter.eisentraut@2ndquadrant.com>

View thread View on postgr.es
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: John Naylor <john.naylor@2ndquadrant.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2020-01-20T08:59:34Z
Lists: pgsql-hackers 
On 2020-01-15 01:37, Tom Lane wrote:
> Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
>> Committed, thanks.
> 
> This patch is making src/tools/pginclude/headerscheck unhappy:
> 
> ./src/include/common/unicode_combining_table.h:3: error: array type has incomplete element type
> 
> I guess that header needs another #include, or else you need to
> move some declarations around.

Hmm, this file is only meant to be included inside one particular 
function.  Making it standalone includable would seem to be unnecessary. 
  What should we do?

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Commits

  1. Add exclusion to headercheck

  2. Add support for automatically updating Unicode derived files