Re: Support for NSS as a libpq TLS backend
Daniel Gustafsson <daniel@yesql.se>
From: Daniel Gustafsson <daniel@yesql.se>
To: Jacob Champion <pchampion@vmware.com>
Cc: "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>,
"hlinnaka@iki.fi" <hlinnaka@iki.fi>,
"andrew.dunstan@2ndquadrant.com" <andrew.dunstan@2ndquadrant.com>,
"michael@paquier.xyz" <michael@paquier.xyz>,
"thomas.munro@gmail.com" <thomas.munro@gmail.com>,
"andres@anarazel.de" <andres@anarazel.de>,
"sfrost@snowman.net" <sfrost@snowman.net>
Date: 2021-06-23T13:48:59Z
Lists: pgsql-hackers
Attachments
- v38-0010-nss-Build-infrastructure.patch (application/octet-stream) patch v38-0010
- v38-0009-nss-Support-NSS-in-cryptohash.patch (application/octet-stream) patch v38-0009
- v38-0008-nss-Support-NSS-in-sslinfo.patch (application/octet-stream) patch v38-0008
- v38-0007-nss-Support-NSS-in-pgcrypto.patch (application/octet-stream) patch v38-0007
- v38-0006-nss-Documentation.patch (application/octet-stream) patch v38-0006
- v38-0005-nss-pg_strong_random-support.patch (application/octet-stream) patch v38-0005
- v38-0004-test-check-for-empty-stderr-during-connect_ok.patch (application/octet-stream) patch v38-0004
- v38-0003-nss-Add-NSS-specific-tests.patch (application/octet-stream) patch v38-0003
- v38-0002-Refactor-SSL-testharness-for-multiple-library.patch (application/octet-stream) patch v38-0002
- v38-0001-nss-Support-libnss-as-TLS-library-in-libpq.patch (application/octet-stream) patch v38-0001
Attached is a rebased version which incorporates your recent patchset for resource handling, as well as the connect_ok test patch. I've implemented tracking the close_notify alert that you mentioned offlist, but it turns out that the alert callbacks in NSS are of limited use so it close_notify is currently the only checked description. The enum which labels the descriptions in the SSLAlert struct is private, so it's just sending over an anonymous number apart from close_notify which is zero. A few other fixups are included as well, like adapting the pending data read function in the frontend to how the OpenSSL implementation does it. -- Daniel Gustafsson https://vmware.com/
Commits
-
Add tab-completion for CREATE FOREIGN TABLE.
- 74527c3e022d 15.0 cited
-
Add tap tests for the schema publications.
- 6b0f6f79eef2 15.0 cited
-
Move Perl test modules to a better namespace
- b3b4d8e68ae8 15.0 cited
-
Adjust configure to insist on Perl version >= 5.8.3.
- 92e6a98c3636 15.0 cited
-
Simplify code related to compilation of SSL and OpenSSL
- 092b785fad3d 14.0 landed
-
Introduce --with-ssl={openssl} as a configure option
- fe61df7f82aa 14.0 landed
-
Implement support for bulk inserts in postgres_fdw
- b663a4136331 14.0 cited
-
Fix redundant error messages in client tools
- 6be725e70161 14.0 cited
-
doc: Apply more consistently <productname> markup for OpenSSL
- 089da3c4778f 14.0 landed
-
Check ssl_in_use flag when reporting statistics
- 6a5c750f3f72 14.0 cited