Horton

Re: Detect buffer underflow in get_th()

Alexander Kuznetsov <kuznetsovam@altlinux.org>

View thread View on postgr.es
From: Alexander Kuznetsov <kuznetsovam@altlinux.org>
To: Peter Eisentraut <peter@eisentraut.org>, pgsql-hackers@lists.postgresql.org
Cc: nickel@altlinux.org, egori@altlinux.org
Date: 2024-12-13T08:57:18Z
Lists: pgsql-hackers 
Hello, ping?

24.09.2024 17:52, Alexander Kuznetsov wrote:
> Hello,
> 
> is there anything else we can help with or discuss in order to apply this fix?
> 
> 24.07.2024 18:53, Alexander Kuznetsov пишет:
>>
>> 24.07.2024 18:39, Peter Eisentraut wrote:
>>> If it can't happen in practice, maybe an assertion would be enough?
>>>
>>
>> In practice, the function should not receive non-numeric strings either; however, since there is an exception in place for such cases, I thought it would be good to add a check for zero-length input in a similar manner.
>>
>> But of course it's open for discussion and team decision whether this should be addressed as an assertion or handled differently.
>>
> 

-- 
Best regards,
Alexander Kuznetsov

Commits

  1. Detect buffer underflow in get_th()