Horton

Re: [PATCH] Add loongarch native checksum implementation.

YANG Xudong <yangxudong@ymatrix.cn>

View thread View on postgr.es
From: YANG Xudong <yangxudong@ymatrix.cn>
To: John Naylor <john.naylor@enterprisedb.com>
Cc: pgsql-hackers@lists.postgresql.org, wengyanqing@ymatrix.cn, wanghao@ymatrix.cn
Date: 2023-08-08T07:22:34Z
Lists: pgsql-hackers 
On 2023/8/8 14:38, John Naylor wrote:
> 
> It seems that platforms capable of running Postgres 
> only support 64 bit.

I think so.


>  > So I guess using aligned memory access is necessary and I have updated
>  > the comment in the code.
> 
> Okay, so it's not "necessary" in the sense that it's illegal, so I'm 
> thinking we can just re-use the Arm comment language, as in 0002.

Yes. I think it is similar to Arm.


> v4 0001 is the same as v3, but with a draft commit message. I will 
> squash and commit this week, unless there is additional feedback.

Looks good to me. Thanks for the additional patch.

Commits

  1. Update Solution.pm for new LoongArch CRC symbol

  2. Use native CRC instructions on 64-bit LoongArch

  3. Recalculate search_path after ALTER ROLE.