Horton

Re: pg_resetwal tests, logging, and docs update

Peter Eisentraut <peter@eisentraut.org>

View thread View on postgr.es
From: Peter Eisentraut <peter@eisentraut.org>
To: Aleksander Alekseev <aleksander@timescale.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2023-09-29T08:02:28Z
Lists: pgsql-hackers 
On 26.09.23 17:19, Aleksander Alekseev wrote:
>> Attached is an updated patch set where I have split the changes into
>> smaller pieces.  The last two patches still have some open questions
>> about what certain constants mean etc.  The other patches should be settled.
> 
> The patches 0001..0005 seem to be ready and rather independent. I
> suggest merging them and continue discussing the rest of the patches.

I have committed 0001..0005, and also posted a separate patch to discuss 
and correct the behavior of the -c option.  I expect that we will carry 
over this patch set to the next commit fest.

Commits

  1. doc: pg_resetwal: Add comments how the multipliers are derived

  2. pg_resetwal: Add more tests and test coverage

  3. More consistent behavior of GetDataDirectoryCreatePerm on Windows

  4. doc: Improve documentation about pg_resetwal -f option

  5. pg_resetwal: Use frontend logging API

  6. pg_resetwal: Regroup --help output

  7. pg_resetwal: Improve error with wrong/missing data directory

  8. pg_resetwal: Update an obsolete comment