Re: Centralised architecture detection

Greg Burd <greg@burd.me>

From: "Greg Burd" <greg@burd.me>
To: "Tom Lane" <tgl@sss.pgh.pa.us>
Cc: "PostgreSQL Hackers" <pgsql-hackers@lists.postgresql.org>, "Lukas Fittl" <lukas@fittl.com>
Date: 2026-07-03T15:28:50Z
Lists: pgsql-hackers
On Wed, Jul 1, 2026, at 9:20 AM, Tom Lane wrote:
> "Greg Burd" <greg@burd.me> writes:
>> On Tue, Jun 30, 2026, at 9:11 PM, Tom Lane wrote:
>>> Based on that thread, I'm thinking
>>> #if SIZEOF_VOID_P == 8
>
>> I don't see SIZEOF_VOID_P but I do find:
>> #define __SIZEOF_POINTER__ 8
>
> SIZEOF_VOID_P is set up by autoconf/meson via pg_config.h.

facepalm, of course! :)

> So it will be available here.  I'd rather use our own
> symbol because, if other arches emerge with similar issues,
> we can be sure of having a common pattern to follow.
>
> I do see __SIZEOF_POINTER__ getting predefined locally
> (in recent gcc and clang on x86_64), but it's far from clear
> to me how standard, or well-documented, that macro is.
>
> 			regards, tom lane

Was there anything else you needed from me on this one?

best.

-greg



Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →
  1. Fix CPU-identification macros for RISC-V.

  2. Clean up inconsistencies in CPU-identification macros.