Re: Change some Datum to void * for opaque pass-through pointer
Peter Eisentraut <peter@eisentraut.org>
From: Peter Eisentraut <peter@eisentraut.org>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2025-12-28T13:40:03Z
Lists: pgsql-hackers
On 23.12.25 16:07, Tom Lane wrote: > Peter Eisentraut <peter@eisentraut.org> writes: >> Here, Datum was used to pass around an opaque pointer between a group of >> functions. But one might as well use void * for that; the use of Datum >> doesn't achieve anything here and is just distracting. > > We have some APIs where Datum is used to be agnostic about whether > a pointer or an integer is being passed through. on_shmem_exit() > callers make use of both cases, for example. Agreed, those are different situations. > These tsearch functions don't need that, and they aren't adjacent > to places using such an API, so I'm fine with this patch as written. Ok, committed.