Re: [HACKERS] [COMMITTERS] pgsql: Remove pgbench "progress" test pending solution of its timing is (fwd)

Daniel Gustafsson <daniel@yesql.se>

From: Daniel Gustafsson <daniel@yesql.se>
To: David Steele <david@pgmasters.net>
Cc: Fabien COELHO <coelho@cri.ensmp.fr>, Tom Lane <tgl@sss.pgh.pa.us>, Heikki Linnakangas <hlinnaka@iki.fi>, Dmitry Dolgov <9erthalion6@gmail.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2020-07-13T10:21:55Z
Lists: pgsql-hackers
> On 8 Apr 2020, at 14:58, David Steele <david@pgmasters.net> wrote:
> 
> On 3/28/20 5:27 AM, Fabien COELHO wrote:
>> Hello Tom,
>> Thanks for your feedback,
>>>> I'd be rather unclear about what the actual feedback is, though. I'd
>>>> interpret it as "pg does not care much about code coverage". Most clients
>>>> are in the red on coverage.postgresql.org. I'd like pgbench at least to be
>>>> in the green, but it does not look that it will ever be the case.
>>> The reason why the first iteration failed was that it was insufficiently
>>> insensitive to timing.
> 
> This patch has been marked Returned with Feedback.
> 
> If the TAP tests could be made to work without the special exceptions added to pgbench.c I think this patch would have a better chance.

Turns out it wasn't, but I'm doing that now since this has been stalled since.

cheers ./daniel


Commits

  1. Refactor code to print pgbench progress reports.

  2. Fix pgbench TAP test to work in VPATH builds.