Re: USE_AUSTRALIAN_RULES breaks regression tests in 7.1.2?
Justin Clift <aa2@bigpond.net.au>
From: Justin Clift <aa2@bigpond.net.au>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-general@postgresql.org
Date: 2001-06-07T11:07:15Z
Lists: pgsql-general
Would it be possible to use the USE_AUSTRALIAN_RULES compile option to only change the default of a USE_AUSTRALIAN_RULES GUC runtime option to be on? Hmmm... then again that's kind of useless. It sounds like it should be a GUC runtime option as you suggest, and that's about it. Anyone want to put that on the TODO list? :-) Regards and best wishes, Justin Clift On Thursday 07 June 2001 19:49, Tom Lane wrote: > Justin Clift <aa2@bigpond.net.au> writes: > > a) Make the regression tests run in the GMT timezone (+0, no DST, etc) > > and have the expected results also be in GMT. > > Not good since that would disable all exercising of DST-related > functionality. > > > b) Have an alternate set of results available for the timestamp and > > horology tests, automatically used when the regression tests are run with > > USE_AUSTRALIAN_RULES. > > Also not good, from a maintenance standpoint --- we have enough variants > of those files already :-(. > > I am inclined to think that treating USE_AUSTRALIAN_RULES as a compile > time option was the wrong idea. It should be a runtime (GUC) option; > then it can be switched off to run the regress tests, regardless of > whether a particular installation keeps it on by default. > > regards, tom lane