Re: [HACKERS] [PATCH] kNN for SP-GiST

Hi!


> 4 июля 2018 г., в 3:21, Nikita Glukhov <n.gluhov@postgrespro.ru> написал(а):
> Attached 5th version of the patches, where minor refactoring of distance 
> handling was done (see below).
> 

I'm reviewing this patch. Currently I'm trying to understand sp-gist scan deeeper, but as for now have some small notices.

Following directives can be omitted:
#include "lib/rbtree.h"
#include "storage/relfilenode.h"

This message is not noly GiST related, is it?
elog(ERROR, "GiST operator family's FOR ORDER BY operator must return float8 or float4 if the distance function is lossy");

Some small typos:
usefull -> useful
nearest-neighbour -> nearest-neighbor (or do we use e.g. "colour"?)

Best regards, Andrey Borodin.