Horton

Re: GUC names in messages

Peter Eisentraut <peter@eisentraut.org>

View thread View on postgr.es
From: Peter Eisentraut <peter@eisentraut.org>
To: Michael Paquier <michael@paquier.xyz>, Peter Smith <smithpb2250@gmail.com>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>, Nathan Bossart <nathandbossart@gmail.com>, Laurenz Albe <laurenz.albe@cybertec.at>, Tom Lane <tgl@sss.pgh.pa.us>, Daniel Gustafsson <daniel@yesql.se>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2023-11-30T20:38:03Z
Lists: pgsql-hackers 
On 30.11.23 06:59, Michael Paquier wrote:
>   			ereport(elevel,
>   					(errcode(ERRCODE_UNDEFINED_OBJECT),
> -					 errmsg("unrecognized configuration parameter \"%s\" in file \"%s\" line %d",
> -							item->name,
> +			/* translator: %s%s%s is for an optionally quoted GUC name */
> +					 errmsg("unrecognized configuration parameter %s%s%s in file \"%s\" line %d",
> +							GUC_FORMAT(item->name),
>   							item->filename, item->sourceline)));

I think this is completely over-engineered and wrong.  If we start down 
this road, then the next person is going to start engineering some rules 
by which we should quote file names and other things.  Which will lead 
to more confusion, not less.  The whole point of this quoting thing is 
that you do it all the time or not, not dynamically based on what's 
inside of it.

The original version of this string (and similar ones) seems the most 
correct, simple, and useful one to me.

Commits

  1. Apply GUC name from central table in more places of guc.c

  2. Use camel case for "DateStyle" in some error messages

  3. Unify some error messages to ease work of translators

  4. Apply more quoting to GUC names in messages

  5. Revise GUC names quoting in messages again

  6. doc: Mention how to use quotes with GUC names in error messages

  7. Apply quotes more consistently to GUC names in logs