Re: [PATCH] Add native windows on arm64 support

Andrew Dunstan <andrew@dunslane.net>

From: Andrew Dunstan <andrew@dunslane.net>
To: Tom Lane <tgl@sss.pgh.pa.us>, Andres Freund <andres@anarazel.de>
Cc: Michael Paquier <michael@paquier.xyz>, Niyas Sait <niyas.sait@linaro.org>, Ian Lawrence Barwick <barwick@gmail.com>, Thomas Munro <thomas.munro@gmail.com>, Julien Rouhaud <rjuju123@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, robhenry@microsoft.com, "Jonathan S. Katz" <jkatz@postgresql.org>, Alvaro Herrera <alvherre@2ndquadrant.com>, Amit Kapila <amit.kapila16@gmail.com>
Date: 2023-05-10T13:24:39Z
Lists: pgsql-hackers
On 2023-05-08 Mo 15:58, Tom Lane wrote:
> Andres Freund<andres@anarazel.de>  writes:
>> I don't really have feelings either way - but haven't we gone further and even
>> backpatched things like spinlock support for new arches in the past?
> Mmmm ... don't really think those cases were comparable.  We weren't
> adding support for a whole new OS.  Now, you might argue that Windows
> on arm64 will be just like Windows on x86_64, but I think the jury
> is still out on that.  Microsoft was so Intel-only for so many years
> that I bet they've had to change quite a bit to make it go on ARM.
>
> Also, the cases of back-patched spinlock support that I can find
> in the last few years were pretty low-risk.  I'll grant that
> c32fcac56 was a bit blue-sky because hardly anybody had RISC-V
> at that point, but by the same token anybody relying on it at the
> time would be dealing with a beta-grade OS too.  On the other hand,
> 1c72d82c2 was immediately testable in the buildfarm, and f3bd00c01
> was importing code already verified by our OpenBSD packagers.
>
> As I said upthread, this seems like something to put in at the
> beginning of a dev cycle, not post-feature-freeze.
> 			


We will definitely want buildfarm support. I don't have such a machine 
and am not likely to have one any time soon. I do run drongo and 
fairywren on an EC2 instance, but AWS doesn't seem to have support for 
Windows on ARM. Maybe it's available on Azure (maybe then some of our 
colleagues working at Microsoft could arrange such a beast for me to set 
up potential buildfarm animal, or else run one themselves.)



cheers


andrew

--
Andrew Dunstan
EDB:https://www.enterprisedb.com

Commits

  1. MSVC: Support building for AArch64.

  2. Remove "#ifdef WIN32" guards from src/port/win32*.c

  3. Adjust XML test case to avoid unstable behavior.

  4. Enable RandomizedBaseAddress (ASLR) on Windows with MSVC builds