Re: pgsql_fdw in contrib

Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>

View thread

From: "Etsuro Fujita" <fujita.etsuro@lab.ntt.co.jp>

To: "'Kohei KaiGai'" <kaigai@kaigai.gr.jp>, "'Shigeru HANADA'" <shigeru.hanada@gmail.com>

Cc: "'PostgreSQL-development'" <pgsql-hackers@postgresql.org>

Date: 2012-07-12T10:10:40Z

Lists: pgsql-hackers

Attachments

pgsql_fdw_regress.patch (application/octet-stream) patch

> 2012/6/26 Kohei KaiGai <kaigai@kaigai.gr.jp>:
> > Harada-san,
> >
> > I checked your patch, and had an impression that includes many
> > improvements from the previous revision that I looked at the last
> > commit fest.
> >
> > However, I noticed several points to be revised, or investigated.
> >
> > * It seems to me expected results of the regression test is not
> >   attached, even though test cases were included. Please add it.

KaiGai-san, Did you find the file?  That is in the contrib/pgsql_fdw/expected
directory, named pgsql_fdw.out.  If necessary, I will send the file to you.
BTW, I found some bugs on the expected results of the file.  Attached is a patch
fixing the bugs.

Thanks,

Best regards,
Etsuro Fujita