Thread

Re: [PATCH] Improve REPACK (CONCURRENTLY) error messages for unsupported configurations

Álvaro Herrera <alvherre@kurilemu.de> — 2026-05-29T10:43:03Z

On 2026-05-29, Baji Shaik wrote:

> LGTM, thanks for adding these.
>
> FWIW I see a couple more uncovered ereport(ERROR) paths 1/ invalid
> index (line 813) 2/ shared catalog with USING INDEX (line 580,
> needs allow_system_table_mods). But both need unusual setup, so
> fine to leave them along with the temp table one. 

Yeah.  I think we could still cover the one in line 580, maybe in test_decoding, but I didn't try. I'm not as excited about this one though; I'm ok to leave it as-is.  Anyway, I have pushed the patch, together with moving some previous tests to test_decoding, because the error message added by your initial 0001 caused wal_level=minimal tests to fail, as shown by thorntail
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=thorntail&dt=2026-05-29%2006%3A31%3A03


Thanks!

-- 
Álvaro Herrera