Re: Fixing syslogger rotation logic for first-time case
Amit Kapila <amit.kapila@huawei.com>
From: Amit Kapila <amit.kapila@huawei.com>
To: "'Tom Lane'" <tgl@sss.pgh.pa.us>, <pgsql-hackers@postgreSQL.org>
Date: 2012-08-01T12:59:01Z
Lists: pgsql-hackers
> From: pgsql-hackers-owner@postgresql.org [mailto:pgsql-hackers-owner@postgresql.org] > On Behalf Of Tom Lane > We've had a couple of complaints recently from people who were unhappy because the > syslogger's log_truncate_on_rotation logic does not fire during the first log rotation > after it's forked off from the postmaster. >Any objections? I have done the testing as per issue reported and below is result of same. Configuration ---------------------- logging_collector = on log_directory = 'pg_log' log_filename = 'postgresql-%H.log' log_truncate_on_rotation = on log_rotation_age = 1h log_rotation_size = 0 Behavior without the fix -------------------------------- 1. Problem was that on first time rotation syslogger was appending data. Behavior After the Patch -------------------------------- 1. Startup time file should be appended. -- working fine 2. On first rotation it should truncate the log file -- working fine With Regards, Amit Kapila.