Re: Remove MSVC scripts from the tree
Peter Eisentraut <peter@eisentraut.org>
From: Peter Eisentraut <peter@eisentraut.org>
To: vignesh C <vignesh21@gmail.com>, Michael Paquier <michael@paquier.xyz>
Cc: Shubham Khanna <khannashubham1197@gmail.com>,
Andres Freund <andres@anarazel.de>,
Postgres hackers <pgsql-hackers@lists.postgresql.org>
Date: 2023-12-18T13:52:41Z
Lists: pgsql-hackers
On 18.12.23 11:49, vignesh C wrote: > Few comments: > 1) Now that the MSVC build scripts are removed, should we have the > reference to "MSVC build scripts" here? > ltree.h: I think this note is correct and can be kept, as it explains the historical context. > 2) I had seen that if sed/gzip is not available meson build will fail: > 2.a) > Program gsed sed found: NO > meson.build:334:6: ERROR: Program 'gsed sed' not found or not executable Yes, this would need to be improved. Currently, sed is only required if either selinux or dtrace is enabled, which isn't supported on Windows. But we should adjust the build scripts to not fail the top-level setup run unless those options are enabled. > 2.b) > Program gzip found: NO > meson.build:337:7: ERROR: Program 'gzip' not found or not executable gzip is only required for certain test suites, so again we should adjust the build scripts to not fail the build but instead skip the tests as appropriate.
Commits
-
Make win32tzlist.pl checkable again
- 8ddf9c1dc020 17.0 landed
-
meson: Make gzip and tar optional
- 9ca6e7b9411e 17.0 landed
-
meson: Make sed optional
- 9aa374dcfb76 17.0 landed
-
Remove MSVC scripts
- 1301c80b2167 17.0 landed
-
Replace Gen_dummy_probes.sed with Gen_dummy_probes.pl
- 3849fe7c2ba7 17.0 landed