Thread

1. [WIP] Patch : Change pg_ident.conf parsing to be the same as pg_hba.conf

   Amit Kapila <amit.kapila@huawei.com> — 2012-07-02T12:08:22Z

   Attached is a Patch to change the parsing of pg_ident.conf to make it
   similar to pg_hba.conf. 
   This is based on Todo Item: 
   http://archives.postgresql.org/pgsql-hackers/2011-06/msg02204.php 
   
   Purpose - This will allow to catch syntax errors in pg_ident at the startup
   or reload time.
     
     
   Changes are described as follows: 
   a.      Make the load_ident() functionality same as load_hba, such that it
   cleans the previous context, after successful parsing. 
   b.      Change the load_ident(), so that parsing can be done during load
   time and the parsed lines are saved. 
   c.      Change the functionality of parse_ident_usermap() so that parsing is
   not done during authentication. 
   d.      If load_ident() fails for parsing, it returns false and error is
   issued. 
           This point I am not sure, as for pg_hba failure it issues FATAL at
   startup. Currently I have kept error handling for load of pg_ident same as
   pg_hba  
     
   I have done the basic testing and test is still in progress. 
     
   Suggestions? 
     
     
   With Regards, 
   Amit Kapila. 
   
    
   
   

2. Re: [WIP] Patch : Change pg_ident.conf parsing to be the same as pg_hba.conf

   Heikki Linnakangas <hlinnakangas@vmware.com> — 2012-09-21T14:58:34Z

   On 02.07.2012 15:08, Amit Kapila wrote:
   > Attached is a Patch to change the parsing of pg_ident.conf to make it
   > similar to pg_hba.conf.
   > This is based on Todo Item:
   > http://archives.postgresql.org/pgsql-hackers/2011-06/msg02204.php
   >
   > Purpose - This will allow to catch syntax errors in pg_ident at the startup
   > or reload time.
   >
   >
   > Changes are described as follows:
   > a.      Make the load_ident() functionality same as load_hba, such that it
   > cleans the previous context, after successful parsing.
   > b.      Change the load_ident(), so that parsing can be done during load
   > time and the parsed lines are saved.
   > c.      Change the functionality of parse_ident_usermap() so that parsing is
   > not done during authentication.
   > d.      If load_ident() fails for parsing, it returns false and error is
   > issued.
   
   Looks good to me, committed with some small cleanup.
   
   >          This point I am not sure, as for pg_hba failure it issues FATAL at
   > startup. Currently I have kept error handling for load of pg_ident same as
   > pg_hba
   
   I think we should be more lenient with pg_ident.conf, and behave as if 
   the file was empty. That is the old behavior, and it seems sensible. You 
   can still connect using an authentication method that doesn't use 
   pg_ident.conf, but if pg_hba.conf is missing, you cannot log in at all.
   
   Thanks!
   
   - Heikki
   
   
   

3. Re: [WIP] Patch : Change pg_ident.conf parsing to be the same as pg_hba.conf

   Amit Kapila <amit.kapila@huawei.com> — 2012-09-22T03:57:08Z

   On Friday, September 21, 2012 8:28 PM Heikki Linnakangas wrote:
   On 02.07.2012 15:08, Amit Kapila wrote:
   >> Attached is a Patch to change the parsing of pg_ident.conf to make it
   >> similar to pg_hba.conf.
   >> This is based on Todo Item:
   >> http://archives.postgresql.org/pgsql-hackers/2011-06/msg02204.php
   >
   >> Purpose - This will allow to catch syntax errors in pg_ident at the startup
   >> or reload time.
   >
   
   > Looks good to me, committed with some small cleanup.
   
   Thank you.
   
   With Regards,
   Amit Kapila.