Re: [PATCH] remove pg_archivecleanup and pg_standby

Heikki Linnakangas <hlinnaka@iki.fi>

From: Heikki Linnakangas <hlinnaka@iki.fi>
To: Justin Pryzby <pryzby@telsasoft.com>, Michael Banck <michael.banck@credativ.de>, "masao.fujii@gmail.com" <masao.fujii@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Stephen Frost <sfrost@snowman.net>, Ian Lawrence Barwick <barwick@gmail.com>, pgsql-hackers@postgresql.org
Date: 2020-11-03T15:28:46Z
Lists: pgsql-hackers
On 02/11/2020 20:26, Justin Pryzby wrote:
> On Thu, Oct 29, 2020 at 08:40:31PM +0100, Michael Banck wrote:
>> Am Mittwoch, den 28.10.2020, 21:44 -0500 schrieb Justin Pryzby:
>>> Forking this thread:
>>> https://www.postgresql.org/message-id/fd93f1c5-7818-a02c-01e5-1075ac0d4def@iki.fi
> 
>>> I think these are old-fashioned since 9.6 (?), so remove them for v14.
>>
>> Why 9.6?
> 
> My work doesn't currently bring me in contact with replication, so I've had to
> dig through release notes.  I think streaming replication was new in 9.0, and
> increasingly mature throughout 9.x.  Maybe someone else will say a different
> release was when streaming replication became the norm and wal shipping old.

Removing pg_standby has been proposed a couple of times in the past. See 
https://www.postgresql.org/message-id/20170913064824.rqflkadxwpboabgw@alap3.anarazel.de 
for the latest attempt.

Masao-san, back in 2014 you mentioned "fast failover" as a feature that 
was missing from the built-in standby mode 
(https://www.postgresql.org/message-id/CAHGQGwEE_8vvpQk0ex6Qa_aXt-OSJ7OdZjX4uM_FtqKfxq5SbQ%40mail.gmail.com). 
I think that's been implemented since, with the recovery_target 
settings. Would you agree?

I'm pretty sure we can remove pg_standby by now. But if there's 
something crucial missing from the built-in facilities, we need to talk 
about implementing them.

- Heikki



Commits

  1. Remove documentation of waiting restore_command.

  2. Retire pg_standby.

  3. doc: Fix typos