Horton
Menu

Re: Typos in the code and README

Andres Freund <andres@anarazel.de>

View thread
From: Andres Freund <andres@anarazel.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Michael Paquier <michael@paquier.xyz>, Alexander Lakhin <exclusion@gmail.com>, David Rowley <dgrowleyml@gmail.com>, PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>, Daniel Gustafsson <daniel@yesql.se>, Heikki Linnakangas <hlinnaka@iki.fi>
Date: 2026-01-05T21:50:59Z
Lists: pgsql-hackers 
Hi,

On 2026-01-05 16:43:02 -0500, Tom Lane wrote:
> Andres Freund <andres@anarazel.de> writes:
> > Your recent commit unfortunately doesn't build with meson, due to headers now
> > not just residing in src/include/snowball/ but also
> > src/include/snowball/libstemmer/.
> 
> Yeah --- but that was true before too.  I don't quite see how
> it built under meson before.

Previously the only thing including snowball/libstemmer/*h files was
src/backend/snowball/dict_snowball.c, which included them relative to
src/includ. But now they are also included from
src/backend/snowball/libstemmer/stem_*.c, just as
> #include "stem_*.h"
thereby requiring include/snowball/libstemmer to be an include path.

Greetings,

Andres Freund

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Fix typo in planner.c

  2. Fix meson build of snowball code.

  3. Update to latest Snowball sources.

  4. Remove unneeded defines from pg_config.h.in

  5. Fix typos and inconsistencies in code and comments

  6. Fix a few more duplicate words in comments

  7. Fix a few duplicate words in comments

  8. Fix typos and grammar in the code

  9. Fix an assortment of spelling mistakes and typos

  10. Fix inconsistent LWLock tranche name "CommitTsSLRU"

  11. Fix typos in code comments and test data

  12. Fix typos and grammar in code comments and docs

  13. Fix a series of typos and outdated references

  14. Optimize InvalidateAttoptCacheCallback() and TypeCacheTypCallback()

  15. pg_upgrade: Remove unused macro

  16. pgcrypto: Remove unused binary from clean target

  17. Fix an assortment of typos

  18. Fix duplicated consecutive words in comments

  19. Remove unused function prototype

  20. Fix incorrect parameter name in prototype

  21. Fix typos and duplicate words

  22. Speedup 2PC recovery by skipping two phase state files in normal path

  23. Two-phase commit. Original patch by Heikki Linnakangas, with additional