Re: merge psql ef/ev sf/sv handling functions
Victor Drobny <v.drobny@postgrespro.ru>
From: Victor Drobny <v.drobny@postgrespro.ru>
To: Fabien COELHO <coelho@cri.ensmp.fr>
Cc: PostgreSQL Developers <pgsql-hackers@postgresql.org>
Date: 2017-07-18T12:10:24Z
Lists: pgsql-hackers
On 2017-03-31 21:04, Fabien COELHO wrote: > Hello, > > While reviewing Corey's \if patch, I complained that there was some > amount of copy-paste in "psql/command.c". > > Here is an attempt at merging some functions which removes 160 lines of > code. Hello, I was looking through your patch. It seems good, the of the functions was very similar. I have a question for you. What was the reason to replace "printfPQExpBuffer" by "resetPQExpBuffer" and "appendPQExpBufferStr"? Thank you for attention! -- ------ Victor Drobny Postgres Professional: http://www.postgrespro.com The Russian Postgres Company
Commits
-
Merge duplicative code for \sf/\sv, \ef/\ev in psql/command.c.
- ca4e20fde87d 11.0 landed