Re: Mismatch in libpqwalreceiver

Fujii Masao <masao.fujii@gmail.com>

View thread

From: Fujii Masao <masao.fujii@gmail.com>

To: Hitoshi Harada <umi.tanuki@gmail.com>

Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>

Date: 2010-03-24T01:02:27Z

Lists: pgsql-hackers

Attachments

walreceiver_readme_v1.patch (application/octet-stream) patch v1

On Wed, Mar 24, 2010 at 1:49 AM, Hitoshi Harada <umi.tanuki@gmail.com> wrote:
> There's a mismatch in HEAD between README and the actual definition in
> replication/libpqwalreceiver.
>
> In README,
>
> bool walrcv_receive(int timeout, XLogRecPtr *recptr, char **buffer, int *len)
>
> but in walreceiver.h,
>
> typedef bool (*walrcv_receive_type) (int timeout, unsigned char *type,
>                                                                                                 char **buffer, int *len);
>
>
> It seems this commit forgot README fix.
>
> http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/replication/walreceiver.h?r1=1.5&r2=1.6

Thanks for the report! That is my mistake. Here is the patch.

Regards,

-- 
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center