Thread

1. recovery.conf.sample

   Fujii Masao <masao.fujii@gmail.com> — 2010-02-23T04:44:40Z

   Hi,
   
   recovery.conf.sample has the following section for Hot Standby.
   Is this still required?
   
   > #---------------------------------------------------------------------------
   > # HOT STANDBY PARAMETERS
   > #---------------------------------------------------------------------------
   > #
   > # If you want to enable read-only connections during recovery, enable
   > # recovery_connections in postgresql.conf
   > #
   > #---------------------------------------------------------------------------
   
   
   Heikki classified the recovery options into the following three
   groups, in the document.
   
       26.1. Archive recovery settings
       26.2. Recovery target settings
       26.3. Standby server settings
   
   OTOH, recovery.conf.sample has classified them into the following
   two groups. This is inconsistent with the document, and looks
   confusing. How about modifying recovery.conf.sample to make the
   grouping the same?
   
       ARCHIVE RECOVERY PARAMETERS
       LOG-STREAMING REPLICATION PARAMETERS
   
   Regards,
   
   -- 
   Fujii Masao
   NIPPON TELEGRAPH AND TELEPHONE CORPORATION
   NTT Open Source Software Center
   
   

2. Re: recovery.conf.sample

   Fujii Masao <masao.fujii@gmail.com> — 2010-03-03T12:51:29Z

   On Tue, Feb 23, 2010 at 1:44 PM, Fujii Masao <masao.fujii@gmail.com> wrote:
   > recovery.conf.sample has the following section for Hot Standby.
   > Is this still required?
   >
   >> #---------------------------------------------------------------------------
   >> # HOT STANDBY PARAMETERS
   >> #---------------------------------------------------------------------------
   >> #
   >> # If you want to enable read-only connections during recovery, enable
   >> # recovery_connections in postgresql.conf
   >> #
   >> #---------------------------------------------------------------------------
   >
   >
   > Heikki classified the recovery options into the following three
   > groups, in the document.
   >
   >    26.1. Archive recovery settings
   >    26.2. Recovery target settings
   >    26.3. Standby server settings
   >
   > OTOH, recovery.conf.sample has classified them into the following
   > two groups. This is inconsistent with the document, and looks
   > confusing. How about modifying recovery.conf.sample to make the
   > grouping the same?
   >
   >    ARCHIVE RECOVERY PARAMETERS
   >    LOG-STREAMING REPLICATION PARAMETERS
   
   The attached patch removes the unnecessary section about HS from
   recovery.conf.sample. Also it changes the grouping of parameters
   in recovery.conf.sample as mentioned above.
   
   Regards,
   
   -- 
   Fujii Masao
   NIPPON TELEGRAPH AND TELEPHONE CORPORATION
   NTT Open Source Software Center
   

3. Re: recovery.conf.sample

   Simon Riggs <simon@2ndquadrant.com> — 2010-04-06T11:41:52Z

   On Wed, 2010-03-03 at 21:51 +0900, Fujii Masao wrote:
   
   > The attached patch removes the unnecessary section about HS from
   > recovery.conf.sample. Also it changes the grouping of parameters
   > in recovery.conf.sample as mentioned above.
   
   I think that comment block is useful for people to remind them that some
   relevant parameters need to be set in postgresql.conf. They might
   otherwise try to put them in recovery.conf and be surprised by the
   result.
   
   -- 
    Simon Riggs           www.2ndQuadrant.com
   
   
   

4. Re: recovery.conf.sample

   Heikki Linnakangas <heikki.linnakangas@enterprisedb.com> — 2010-04-06T14:55:05Z

   Fujii Masao wrote:
   > On Tue, Feb 23, 2010 at 1:44 PM, Fujii Masao <masao.fujii@gmail.com> wrote:
   >> recovery.conf.sample has the following section for Hot Standby.
   >> Is this still required?
   >>
   >>> #---------------------------------------------------------------------------
   >>> # HOT STANDBY PARAMETERS
   >>> #---------------------------------------------------------------------------
   >>> #
   >>> # If you want to enable read-only connections during recovery, enable
   >>> # recovery_connections in postgresql.conf
   >>> #
   >>> #---------------------------------------------------------------------------
   >>
   >> Heikki classified the recovery options into the following three
   >> groups, in the document.
   >>
   >>    26.1. Archive recovery settings
   >>    26.2. Recovery target settings
   >>    26.3. Standby server settings
   >>
   >> OTOH, recovery.conf.sample has classified them into the following
   >> two groups. This is inconsistent with the document, and looks
   >> confusing. How about modifying recovery.conf.sample to make the
   >> grouping the same?
   >>
   >>    ARCHIVE RECOVERY PARAMETERS
   >>    LOG-STREAMING REPLICATION PARAMETERS
   > 
   > The attached patch removes the unnecessary section about HS from
   > recovery.conf.sample. Also it changes the grouping of parameters
   > in recovery.conf.sample as mentioned above.
   
   I committed the "LOG-STREAMING REPLICATION PARAMETERS" -> "STANDBY
   SERVER PARAMETERS" rename. Simon added the "RECOVERY TARGET PARAMETERS"
   heading already, and he wants to keep the Hot Standby section.
   
   -- 
     Heikki Linnakangas
     EnterpriseDB   http://www.enterprisedb.com