Re: Re: [COMMITTERS] pgsql: Write a WAL record whenever we perform an operation without
Fujii Masao <masao.fujii@gmail.com>
From: Fujii Masao <masao.fujii@gmail.com>
To: Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>
Cc: Simon Riggs <simon@2ndquadrant.com>, pgsql-hackers@postgresql.org
Date: 2010-02-01T10:36:59Z
Lists: pgsql-hackers
On Mon, Feb 1, 2010 at 7:27 PM, Heikki Linnakangas <heikki.linnakangas@enterprisedb.com> wrote: > Fujii Masao wrote: >> The cause of the problem seems to be the new heap created by >> rebuild_relation() and copy_heap_data(), i.e., new VACUUM FULL. >> Since it's not a temporary heap, its rd_istemp is off. OTOH >> it needs to be synced after physical copy from old heap. > > Why does it need to be synced? > > ISTM the bug is that rd_istemp is off at that point. Umm... ISTM that new heap needs to be synced before calling swap_relation_files(), but, in the now, I'm not sure whether it's really required or not. Sorry. Regards, -- Fujii Masao NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center