Horton
Menu

Re: testing cvs HEAD - HS/SR - missing file

Fujii Masao <masao.fujii@gmail.com>

View thread
From: Fujii Masao <masao.fujii@gmail.com>
To: Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>
Cc: Erik Rijkers <er@xs4all.nl>, pgsql-hackers@postgresql.org
Date: 2010-01-27T10:46:36Z
Lists: pgsql-hackers 
On Wed, Jan 27, 2010 at 7:05 PM, Heikki Linnakangas
<heikki.linnakangas@enterprisedb.com> wrote:
> Before that, endptr is advanced using XLByteAdvance() macro, which does
> handle xlogid boundaries. Is XLByteAdvance() broken?

No. The cause of the bug is that endptr might be set to the SendRqstPtr
that has crossed a xlogid boundary in the following code.

>		/* if we went beyond SendRqstPtr, back off */
>		if (XLByteLT(SendRqstPtr, endptr))
>			endptr = SendRqstPtr;

Regards,

-- 
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center