Re: Hot Standby, release candidate?
Fujii Masao <masao.fujii@gmail.com>
From: Fujii Masao <masao.fujii@gmail.com>
To: Simon Riggs <simon@2ndquadrant.com>
Cc: Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>, pgsql-hackers@postgresql.org
Date: 2009-12-14T11:15:47Z
Lists: pgsql-hackers
On Mon, Dec 14, 2009 at 8:07 PM, Simon Riggs <simon@2ndquadrant.com> wrote: >> * Please remove any spurious whitespace. "git diff --color" makes them >> stand out like a sore thumb, in red. (pgindent will fix them but always >> better to fix them before committing, IMO). > > What is your definition of spurious whitespace? I removed all > additions/deletions of individual lines. git diff colours many things > red, and it seems like a waste of time to spend hours fiddling with > spaces manually if there is a utility that does this anyway. I guess it's a trailing whitespace. How about using "git diff --check" instead of "--color"? Regards, -- Fujii Masao NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center