Re: WL_SOCKET_ACCEPT fairness on Windows

Jonathan S. Katz <jkatz@postgresql.org>

From: "Jonathan S. Katz" <jkatz@postgresql.org>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Andres Freund <andres@anarazel.de>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2023-05-16T21:11:29Z
Lists: pgsql-hackers
On 5/16/23 4:41 PM, Thomas Munro wrote:
> On Wed, May 17, 2023 at 2:57 AM Jonathan S. Katz <jkatz@postgresql.org> wrote:

>> Given this has sat for a bit, I wanted to see if any of your thinking
>> has changed on whether this should be fixed for v16 or v17. I have
>> personally not formed an opinion yet, but per the current discussion, it
>> seems like this could wait?
> 
> Yeah.  No one seems to think this is worth worrying about (please
> speak up if you do).  I'll go ahead and remove this from the open item
> lists now, but I'll leave the patch in the CF for 17, to see if a
> Windows hacker/tester thinks it's a worthwhile improvement.

[RMT hat, personal opinion]

That seems reasonable to me.

Thanks,

Jonathan

Commits

  1. Teach WaitEventSetWait() to report multiple events on Windows.

  2. Use WaitEventSet API for postmaster's event loop.