Horton

Re: Convert planner's AggInfo and AggTransInfo to Nodes

Peter Eisentraut <peter.eisentraut@enterprisedb.com>

View thread View on postgr.es
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: Tom Lane <tgl@sss.pgh.pa.us>, pgsql-hackers@lists.postgresql.org
Date: 2022-07-19T15:49:34Z
Lists: pgsql-hackers 
On 18.07.22 18:08, Tom Lane wrote:
> I'm kind of tempted to mount an effort to get rid of as many of
> pathnodes.h's "read_write_ignore" annotations as possible.  Some are
> necessary to prevent infinite recursion, and others represent considered
> judgments that they'd bloat node dumps more than they're worth --- but
> I think quite a lot of them arose from plain laziness about updating
> outfuncs.c.  With the infrastructure we have now, that's no longer
> a good reason.

That was my impression as well, and I agree it would be good to sort 
that out.

Commits

  1. Dump more fields when dumping planner internal data structures.

  2. Make serialization of Nodes' scalar-array fields more robust.

  3. Convert planner's AggInfo and AggTransInfo structs to proper Nodes.