Horton

Re: Support for NO INHERIT to INHERIT state change with named NOT NULL constraints

Peter Eisentraut <peter@eisentraut.org>

View thread View on postgr.es
From: Peter Eisentraut <peter@eisentraut.org>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>, Suraj Kharage <suraj.kharage@enterprisedb.com>
Cc: jian he <jian.universality@gmail.com>, Robert Haas <robertmhaas@gmail.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2025-03-25T10:22:45Z
Lists: pgsql-hackers 
On 05.03.25 13:56, Alvaro Herrera wrote:
> On 2025-Mar-03, Suraj Kharage wrote:
> 
>> Thanks Alvaro for the review and fixup patch.
>>
>> I agree with your changes and merged that into the main patch along with a
>> couple of other changes.
>>
>> Please find attached v6 for further review.
> 
> Thanks, I have pushed this.  I made some changes to the tests, first by
> renaming the tables to avoid too generic names, and second to try and
> exercise everything about once.

A patch in the NOT ENFORCED constraints patch series proposes to 
refactor some of the code added by this patch series ([0] patch 
v18-0001).  I noticed that the code paths from this patch series do not 
call InvokeObjectPostAlterHook() or CacheInvalidateRelcache() when a 
constraint is altered.  Was this intentional?  If not, I can fix it as 
part of that other patch, just wanted to check here.


[0]: 
https://www.postgresql.org/message-id/CAAJ_b97aHsJgWhAuRQi1JdWsjzd_ygWEjqQVq_Ddo8dyCnnwkw@mail.gmail.com

Commits

  1. Small fixes for Add ALTER TABLE ... ALTER CONSTRAINT ... SET [NO] INHERIT

  2. Add ALTER TABLE ... ALTER CONSTRAINT ... SET [NO] INHERIT

  3. Add pg_constraint rows for not-null constraints