Re: mingw32 floating point diff
Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2019-08-23T06:14:06Z
Lists: pgsql-hackers
On 2019-08-22 18:19, Tom Lane wrote: > What I suggest doing is reducing extra_float_digits to -1 for this > specific test. Changing the contents of circle_tbl seems like it'd have > more consequences than we want, in particular there's no guarantee that > we'd not hit similar issues in other tests if they're given different > inputs. I agree that reducing the output precision is better than adjusting the code. The circle.sql file already has SET extra_float_digits TO 0, and a few other files have other settings with different values. Are we content to use various numbers until it works in each case, or should we try to use some consistency? -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Commits
-
Back off output precision in circle.sql regression test.
- faee5a12ecf1 13.0 landed
- cd714b3507c9 12.0 landed