Horton

Re: invalid data in file backup_label problem on windows

Andrew Dunstan <andrew@dunslane.net>

View thread View on postgr.es
From: Andrew Dunstan <andrew@dunslane.net>
To: David Steele <david@pgmasters.net>, Magnus Hagander <magnus@hagander.net>, "wangsh.fnst@fujitsu.com" <wangsh.fnst@fujitsu.com>
Cc: Michael Paquier <michael@paquier.xyz>, "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
Date: 2021-03-26T16:52:24Z
Lists: pgsql-hackers 
On 3/26/21 10:19 AM, David Steele wrote:
>
>> No, the problem is you are using copy/paste and in doing so you are
>> *changing'* the value that is being returned. You'll either need to
>> update your copy/paste procedure to not mess with the newlines, or to
>> use a better way to get the data out.
>>
>> If we need to clarify that in the documentation, I'm fine with that.
>> Maybe add an extra sentence to the part about not modifying the output
>> to mention that this includes changing newslines and also encoding
>> (which would also break it, if you managed to find a non-ascii
>> compatible encoding). Maybe even something along the line of "the
>> contents have to be written in binary mode"?
>
> Perhaps something like the attached?
>
>


That seems a bit opaque.  Let's tell them exactly what they need to avoid.


cheers


andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com

Commits

  1. doc: Clarify how to generate backup files with non-exclusive backups