Horton

Re: [PATCH] test/ssl: rework the sslfiles Makefile target

Andrew Dunstan <andrew@dunslane.net>

View thread View on postgr.es
From: Andrew Dunstan <andrew@dunslane.net>
To: Jacob Champion <pchampion@vmware.com>, "daniel@yesql.se" <daniel@yesql.se>
Cc: "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
Date: 2021-07-28T20:45:07Z
Lists: pgsql-hackers 
On 7/28/21 4:10 PM, Jacob Champion wrote:
>
>>> - I am making _heavy_ use of GNU Make-isms, which does not improve
>>> long-term maintainability.
>> GNU Make is already a requirement, I don't see this shifting the needle in any
>> direction.
> As long as the .SECONDARYEXPANSION magic is clear enough to others, I'm
> happy.
>

We don't currently have any, and so many of us (including me) will have
to learn to understand it. But that's not to say it's unacceptable. If
there's no new infrastructure requirement then I'm OK with it.


cheers


andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com

Commits

  1. Refactor the sslfiles Makefile target for ease of use

  2. Remove unused regression test certificate server-ss