Horton

Re: [PATCH] Implement motd for PostgreSQL

Joel Jacobson <joel@compiler.org>

View thread
From: "Joel Jacobson" <joel@compiler.org>
To: "Fabien COELHO" <coelho@cri.ensmp.fr>
Cc: "PostgreSQL Developers" <pgsql-hackers@lists.postgresql.org>, "Michael Paquier" <michael@paquier.xyz>
Date: 2021-04-04T05:55:16Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Disallow newlines in parameter values to be set in ALTER SYSTEM.

On Sat, Apr 3, 2021, at 17:50, Fabien COELHO wrote:
> > Perhaps the configuration-file parser has been fixed since to support 
> > embedded newlines? If so, then maybe it would actually be an idea to 
> > support newlines by escaping them?
> 
> Dunno.
> 
> If such a feature gets considered, I'm not sure I'd like to actually edit 
> pg configuration file to change the message.

For the ALTER SYSTEM case, the value would be written to postgresql.auto.conf,
and that file we shouldn't edit manually anyway, right?

> 
> The actual source looks pretty straightforward. I'm wondering whether pg 
> style would suggest to write motd != NULL instead of just motd.

That's what I had originally, but when reviewing my code verifying code style,
I noticed the other case it more common:

if \([a-z]* != NULL &&
119 results in 72 files

if \([a-z]* &&
936 results in 311 files

> 
> I'm wondering whether it should be possible to designate (1) a file the 
> content of which would be shown, or (2) a command, the output of which 
> would be shown [ok, there might be security implications on this one].

Can't we just do that via plpgsql and EXECUTE somehow?

/Joel