Re: Bug in ExecModifyTable function and trigger issues for foreign tables

Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>

From: Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Ashutosh Bapat <ashutosh.bapat@enterprisedb.com>, Ildus Kurbangaliev <i.kurbangaliev@postgrespro.ru>, Dilip Kumar <dilipbalaut@gmail.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>, Robert Haas <robertmhaas@gmail.com>
Date: 2017-07-21T10:16:13Z
Lists: pgsql-hackers

Attachments

On 2017/07/20 11:21, Etsuro Fujita wrote:
> On 2017/07/19 23:36, Tom Lane wrote:
>> Please put the responsibility of doing const-expression simplification
>> in these cases somewhere closer to where the problem is being created.
> 
> It would be reasonable that it's the FDW's responsibility to do that 
> const-simplification if necessary?
There seems to be no objections, so I removed the const-expression 
simplification from the patch and I added the note to the docs for 
AddForeignUpdateTargets.

Attached is an updated version of the patch.

Best regards,
Etsuro Fujita

Commits

  1. Fix creation of resjunk tlist entries for inherited mixed UPDATE/DELETE.