redundant error messages
Peter Eisentraut <peter.eisentraut@enterprisedb.com>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2020-11-05T12:27:21Z
Lists: pgsql-hackers
Attachments
- 0001-Fix-redundant-error-messages-in-client-tools.patch (text/plain) patch 0001
A few client tools duplicate error messages already provided by libpq, such as pg_rewind: fatal: could not connect to server: could not connect to server: No such file or directory pg_basebackup: error: could not connect to server: could not connect to server: No such file or directory psql: error: could not connect to server: could not connect to server: No such file or directory The psql case is actually a regression introduced in PG12, but the other two appear to be ancient. Other client tools provide a different error message so in aggregate it looks like this: createdb: error: could not connect to database template1: could not connect to server: No such file or directory The attached patch removes the redundant message from the client tools. I suppose it's a bit dubious because there is no guarantee what the level of detail the message supplied by libpq has. But I think these few cases are not particularly hard to keep in sync.
Commits
-
Fix redundant error messages in client tools
- 6be725e70161 14.0 landed
- f3ad4fddfaf7 13.1 landed
- 24bbdaa6feac 9.5.24 landed
- 8096be26178b 9.6.20 landed
- 468bed27ce8d 10.15 landed
- 42c088be1889 11.10 landed
- 16eadc4695ef 12.5 landed