Horton

Re: DROP DATABASE is interruptible

Peter Eisentraut <peter@eisentraut.org>

View thread View on postgr.es
From: Peter Eisentraut <peter@eisentraut.org>
To: Andres Freund <andres@anarazel.de>, Daniel Gustafsson <daniel@yesql.se>
Cc: Thomas Munro <thomas.munro@gmail.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>, Evgeny Morozov <postgresql3@realityexists.net>, Tom Lane <tgl@sss.pgh.pa.us>
Date: 2023-09-25T00:48:31Z
Lists: pgsql-hackers 
I noticed that this patch set introduced this pg_dump test:

On 12.07.23 03:59, Andres Freund wrote:
> +	'CREATE DATABASE invalid...' => {
> +		create_order => 1,
> +		create_sql => q(CREATE DATABASE invalid; UPDATE pg_database SET datconnlimit = -2 WHERE datname = 'invalid'),
> +		regexp => qr/^CREATE DATABASE invalid/m,
> +		not_like => {
> +			pg_dumpall_dbprivs => 1,
> +		},
> +	},

But the key "not_like" isn't used for anything by that test suite. 
Maybe "unlike" was meant?  But even then it would be useless because the 
"like" key is empty, so there is nothing that "unlike" can subtract 
from.  Was there something expected from the mention of 
"pg_dumpall_dbprivs"?

Perhaps it would be better to write out

     like => {},

explicitly, with a comment, like some other tests are doing.

Commits

  1. pg_dump: tests: Correct test condition for invalid databases

  2. Handle DROP DATABASE getting interrupted