Horton

Thread

Commits

  1. Add 'id' to Acknowledgments section

  1. tickling the lesser contributor's withering ego

    Erik Rijkers <er@xs4all.nl> — 2018-11-04T14:38:47Z

    I wouldn't mind if this page:
   https://www.postgresql.org/community/contributors/

contained a link to (contributors v11):
   
https://www.postgresql.org/docs/11/static/release-11.html#id-1.11.6.5.6

and to (contributors v10)
   
https://www.postgresql.org/docs/current/static/release-11.html#id-1.11.6.5.6

In fact, I think I would like it.

I hope you agree.


thanks,


Erik Rijkers

  2. Re: tickling the lesser contributor's withering ego

    Alvaro Herrera <alvherre@2ndquadrant.com> — 2018-12-21T14:38:42Z

    On 2018-Nov-04, Erik Rijkers wrote:

> I wouldn't mind if this page:
>   https://www.postgresql.org/community/contributors/
> 
> contained a link to (contributors v11):
> https://www.postgresql.org/docs/11/static/release-11.html#id-1.11.6.5.6
> 
> and to (contributors v10)
> https://www.postgresql.org/docs/current/static/release-11.html#id-1.11.6.5.6

I propose the following patch, which will make those links stable --
then we can add the following links to the contributors page:

https://www.postgresql/org/docs/10/release-10.html#RELEASE-10-ACKNOWLEDGEMENTS
https://www.postgresql/org/docs/11/release-11.html#RELEASE-11-ACKNOWLEDGEMENTS

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

  3. Re: tickling the lesser contributor's withering ego

    Tom Lane <tgl@sss.pgh.pa.us> — 2018-12-21T14:45:23Z

    Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> I propose the following patch, which will make those links stable --
> then we can add the following links to the contributors page:
> https://www.postgresql/org/docs/10/release-10.html#RELEASE-10-ACKNOWLEDGEMENTS
> https://www.postgresql/org/docs/11/release-11.html#RELEASE-11-ACKNOWLEDGEMENTS

Seems reasonable, but note the lag time --- unless somebody does
something out of the ordinary, those pages won't actually have
such tags till after the February minor releases.

			regards, tom lane

  4. Re: tickling the lesser contributor's withering ego

    Alvaro Herrera <alvherre@2ndquadrant.com> — 2018-12-21T15:17:23Z

    On 2018-Dec-21, Tom Lane wrote:

> Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> > I propose the following patch, which will make those links stable --
> > then we can add the following links to the contributors page:
> > https://www.postgresql/org/docs/10/release-10.html#RELEASE-10-ACKNOWLEDGEMENTS
> > https://www.postgresql/org/docs/11/release-11.html#RELEASE-11-ACKNOWLEDGEMENTS
> 
> Seems reasonable, but note the lag time --- unless somebody does
> something out of the ordinary, those pages won't actually have
> such tags till after the February minor releases.

Good point.  That seems acceptable to me.

Erik, are you willing to propose a patch for the pgweb side of things?

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

  5. Re: tickling the lesser contributor's withering ego

    Erik Rijkers <er@xs4all.nl> — 2018-12-21T15:25:38Z

    On 2018-12-21 16:17, Alvaro Herrera wrote:
> On 2018-Dec-21, Tom Lane wrote:
> 
>> Alvaro Herrera <alvherre@2ndquadrant.com> writes:
>> > I propose the following patch, which will make those links stable --
>> > then we can add the following links to the contributors page:
>> > https://www.postgresql/org/docs/10/release-10.html#RELEASE-10-ACKNOWLEDGEMENTS
>> > https://www.postgresql/org/docs/11/release-11.html#RELEASE-11-ACKNOWLEDGEMENTS
>> 
>> Seems reasonable, but note the lag time --- unless somebody does
>> something out of the ordinary, those pages won't actually have
>> such tags till after the February minor releases.
> 
> Good point.  That seems acceptable to me.
> 
> Erik, are you willing to propose a patch for the pgweb side of things?

Yes, sounds reasonable.  I think I can cobble something together.

  6. Re: tickling the lesser contributor's withering ego

    Magnus Hagander <magnus@hagander.net> — 2018-12-27T10:53:18Z

    On Fri, Dec 21, 2018 at 4:17 PM Alvaro Herrera <alvherre@2ndquadrant.com>
wrote:

> On 2018-Dec-21, Tom Lane wrote:
>
> > Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> > > I propose the following patch, which will make those links stable --
> > > then we can add the following links to the contributors page:
> > >
> https://www.postgresql/org/docs/10/release-10.html#RELEASE-10-ACKNOWLEDGEMENTS
> > >
> https://www.postgresql/org/docs/11/release-11.html#RELEASE-11-ACKNOWLEDGEMENTS
> >
> > Seems reasonable, but note the lag time --- unless somebody does
> > something out of the ordinary, those pages won't actually have
> > such tags till after the February minor releases.
>
> Good point.  That seems acceptable to me.
>

Good. While it *can* be worked around, it's a PITA and it risks getting
overwritten by other things, since the normal docs loads are based off
release tarballs. We can make them off a snapshot tarball, but it's a pain
:)

Oh, and +1 for stable links like that in general. That would be one good
step.

Not having considered what to do with, but it could also be interesting to
teach the loader to read the structured data out of the XML file and store
it in one of these weird things called a "database". That could be used for
things like matching on the contributors list and add a little per-version
badge to which versions they are known to contribute etc. That would
require us to be quite consistent in the naming of people, and also not to
have duplicates though, but maybe it can be valuable?

Actually, do we have a policy for handling duplicates in the docs there?
Since we only keep names there and not email or similar?

-- 
 Magnus Hagander
 Me: https://www.hagander.net/ <http://www.hagander.net/>
 Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

  7. Re: tickling the lesser contributor's withering ego

    Jonathan S. Katz <jkatz@postgresql.org> — 2018-12-27T14:38:24Z

    On 12/27/18 4:53 AM, Magnus Hagander wrote:
> 
> 
> On Fri, Dec 21, 2018 at 4:17 PM Alvaro Herrera <alvherre@2ndquadrant.com
> <mailto:alvherre@2ndquadrant.com>> wrote:
> 
>     On 2018-Dec-21, Tom Lane wrote:
> 
>     > Alvaro Herrera <alvherre@2ndquadrant.com
>     <mailto:alvherre@2ndquadrant.com>> writes:
>     > > I propose the following patch, which will make those links stable --
>     > > then we can add the following links to the contributors page:
>     > >
>     https://www.postgresql/org/docs/10/release-10.html#RELEASE-10-ACKNOWLEDGEMENTS
>     > >
>     https://www.postgresql/org/docs/11/release-11.html#RELEASE-11-ACKNOWLEDGEMENTS
>     >
>     > Seems reasonable, but note the lag time --- unless somebody does
>     > something out of the ordinary, those pages won't actually have
>     > such tags till after the February minor releases.
> 
>     Good point.  That seems acceptable to me.
> 
> 
> Good. While it *can* be worked around, it's a PITA and it risks getting
> overwritten by other things, since the normal docs loads are based off
> release tarballs. We can make them off a snapshot tarball, but it's a
> pain :)
> 
> Oh, and +1 for stable links like that in general. That would be one good
> step.

Agreed on above points.

> 
> Not having considered what to do with, but it could also be interesting
> to teach the loader to read the structured data out of the XML file and
> store it in one of these weird things called a "database". That could be
> used for things like matching on the contributors list and add a little
> per-version badge to which versions they are known to contribute etc.
> That would require us to be quite consistent in the naming of people,
> and also not to have duplicates though, but maybe it can be valuable?

Not to hijack this, but there are some similar(-ish; we can debate
semantics, but it's a similar idea) things mentioned here[1] in
conjunction to the release note trimming. If we are going to go on the
"store stuff in the database" route around additional information the
docs, I'd suggest we tackle the release note trimming as well (and I
volunteer myself for that) as that should have significant impact across
the project (esp. full build time!).

I'm all for highlighting contributors and their work - so perhaps we can
combine both efforts since there might be a common solution to both? :)

(and RE dupes: I also hear that these database things are good tools for
helping to eliminate such things ;-)

Thanks,

Jonathan

[1]
https://www.postgresql.org/message-id/flat/19252.1533509841%40sss.pgh.pa.us

  8. Re: tickling the lesser contributor's withering ego

    Alvaro Herrera <alvherre@2ndquadrant.com> — 2019-01-21T17:47:19Z

    On 2018-Dec-27, Magnus Hagander wrote:

> On Fri, Dec 21, 2018 at 4:17 PM Alvaro Herrera <alvherre@2ndquadrant.com>
> wrote:
> 
> > On 2018-Dec-21, Tom Lane wrote:
> >
> > > Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> > > > I propose the following patch, which will make those links stable --
> > > > then we can add the following links to the contributors page:
> > > > https://www.postgresql/org/docs/10/release-10.html#RELEASE-10-ACKNOWLEDGEMENTS
> > > > https://www.postgresql/org/docs/11/release-11.html#RELEASE-11-ACKNOWLEDGEMENTS
> > >
> > > Seems reasonable, but note the lag time --- unless somebody does
> > > something out of the ordinary, those pages won't actually have
> > > such tags till after the February minor releases.
> >
> > Good point.  That seems acceptable to me.
> 
> Good. While it *can* be worked around, it's a PITA and it risks getting
> overwritten by other things, since the normal docs loads are based off
> release tarballs. We can make them off a snapshot tarball, but it's a pain
> :)
> 
> Oh, and +1 for stable links like that in general. That would be one good
> step.

Okay, pushed this.  There's no need to do any advance publishing I
think; we can wait three more weeks.

We still need Erik to come up with the patch for pgweb, though :-)

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services