Horton

Re: Convert macros to static inline functions

Peter Eisentraut <peter.eisentraut@enterprisedb.com>

View thread View on postgr.es
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2024-12-27T10:16:46Z
Lists: pgsql-hackers

Attachments

On 16.05.22 10:27, Peter Eisentraut wrote:
> Inspired by [0], I looked to convert more macros to inline functions. 

This is an older thread where I left something unfinished:

> Note 2: Many macros in htup_details.h operate both on HeapTupleHeader 
> and on MinimalTuple, so converting them to a function doesn't work in a 
> straightforward way.  I have some in-progress work in that area, but I 
> have not included any of that here.

Here is the patch set for this.

There are actually only two macros that operate on both HeapTupleHeader 
and MinimalTuple, so it wasn't as much as I had written above.  I just 
left those as macros.  I converted the rest to inline functions in a 
straightforward way as before.  A small amount of reordering was necessary.

But just for language-nerd fun, I'm including here an additional patch 
showing how the remaining ones could be done with C11 generic selection. 
  I'm not planning to commit that one at this time.

Commits

  1. Add some const decorations (htup.h)

  2. Convert macros to static inline functions (htup_details.h, itup.h)

  3. Convert macros to static inline functions (rel.h)

  4. Convert macros to static inline functions (itup.h)

  5. Convert macros to static inline functions (tupmacs.h)

  6. Convert macros to static inline functions (xlog_internal.h)

  7. Convert macros to static inline functions (bufmgr.h)

  8. Convert macros to static inline functions (itemptr.h)

  9. Convert macros to static inline functions (bufpage.h)

  10. Convert macros to static inline functions (block.h)