Horton
Menu

Re: BUG #18866: Running pg_freespace() on views triggers an Abort

Euler Taveira <euler@eulerto.com>

View thread
From: "Euler Taveira" <euler@eulerto.com>
To: "Alvaro Herrera" <alvherre@alvh.no-ip.org>
Cc: "Tender Wang" <tndrwang@gmail.com>, "Tom Lane" <tgl@sss.pgh.pa.us>, tharakan@gmail.com, pgsql-bugs@lists.postgresql.org, "Heikki Linnakangas" <hlinnaka@iki.fi>
Date: 2025-03-26T19:00:28Z
Lists: pgsql-bugs 
On Wed, Mar 26, 2025, at 2:33 PM, Álvaro Herrera wrote:
> On 2025-Mar-25, Euler Taveira wrote:
> 
> > On Tue, Mar 25, 2025, at 10:18 PM, Tender Wang wrote:
> > > Thanks for the advice. Please see the attached patch.
> > 
> > Your patch needs some adjustments. There is no need to include pg_class.h.
> 
> I think including pg_class.h (which is where RELKIND_HAS_STORAGE() is
> defined and where errdetail_relkind_not_supported is declared) is better
> than including utils/rel.h, which brings in a whole bunch of additional
> stuff in addition to pg_class.h :-)

It doesn't work because of RelationGetRelationName() that is defined into
utils/rel.h.


--
Euler Taveira
EDB   https://www.enterprisedb.com/

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Prevent assertion failure in contrib/pg_freespacemap.

  2. Don't try to open visibilitymap when analyzing a foreign table