Horton

Re: speed up a logical replica setup

Andrew Dunstan <andrew@dunslane.net>

View thread
From: Andrew Dunstan <andrew@dunslane.net>
To: "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>, 'Euler Taveira' <euler@eulerto.com>, Shlok Kyal <shlok.kyal.oss@gmail.com>
Cc: "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>, vignesh C <vignesh21@gmail.com>, Michael Paquier <michael@paquier.xyz>, Peter Eisentraut <peter@eisentraut.org>, Andres Freund <andres@anarazel.de>, Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>, Amit Kapila <amit.kapila16@gmail.com>, Fabrízio de Royes Mello <fabriziomello@gmail.com>
Date: 2024-02-29T05:01:10Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. pg_createsubscriber: Remove obsolete comment

  2. pg_createsubscriber: Fix an unpredictable recovery wait time.

  3. Fix unstable test in 040_pg_createsubscriber.

  4. Fix the testcase introduced in commit 81d20fbf7a.

  5. Further weaken new pg_createsubscriber test on Windows.

  6. Temporarily(?) weaken new pg_createsubscriber test on Windows.

  7. Make pg_createsubscriber warn if publisher has two-phase commit enabled.

  8. Make pg_createsubscriber more wary about quoting connection parameters.

  9. pg_createsubscriber: Remove failover replication slots on subscriber

  10. pg_createsubscriber: Remove replication slot check on primary

  11. pg_createsubscriber: Only --recovery-timeout controls the end of recovery process

  12. pg_createsubscriber: creates a new logical replica from a standby server

  13. Add some const decorations

  14. Add option force_initdb to PostgreSQL::Test::Cluster:init()

  15. Remove MSVC scripts

On 2024-02-27 Tu 05:02, Hayato Kuroda (Fujitsu) wrote:
> Dear Euler,
>
>> Sorry, which pg_rewind option did you mention? I cannot find.
>> IIUC, -l is an only option which can accept the path, but it is not related with us.
> Sorry, I found [1]. I was confused with pg_resetwal. But my opinion was not so changed.
> The reason why --config-file exists is that pg_rewind requires that target must be stopped,
> which is different from the current pg_createsubscriber. So I still do not like to add options.
>
> [1]: https://www.postgresql.org/docs/current/app-pgrewind.html#:~:text=%2D%2Dconfig%2Dfile%3Dfilename
> [2]:
> ```
> The target server must be shut down cleanly before running pg_rewind
> ```
>

Even though that is a difference I'd still rather we did more or less 
the same thing more or less the same way across utilities, so I agree 
with Euler's suggestion.


cheers


andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com