Re: Pass heaprel to GlobalVisTestFor() in vacuumRedirectAndPlaceholder()
Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
From: "Drouvot, Bertrand" <bertranddrouvot.pg@gmail.com>
To: Andres Freund <andres@anarazel.de>, Peter Geoghegan <pg@bowt.ie>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2023-04-03T07:09:50Z
Lists: pgsql-hackers
Attachments
- v2-0001-make-use-of-heaprel-in-vacuumRedirectAndPlaceholder.patch (text/plain) patch v2-0001
Hi, On 4/3/23 12:30 AM, Andres Freund wrote: > Hi, > > On 2023-04-02 10:22:18 -0700, Peter Geoghegan wrote: >> On Sun, Apr 2, 2023 at 10:18 AM Peter Geoghegan <pg@bowt.ie> wrote: >>> Making nbtree page deletion more efficient when logical decoding is in >>> use seems well worthwhile. There is an "XXX" comment about this issue, >>> similar to the SP-GiST one. It looks like you already have everything >>> you need to make this work from yesterday's commit 61b313e47e. > > +1 > Thanks Peter for the suggestion! > >> Actually, I suppose that isn't quite true, since you'd still need to >> find a way to pass the heap relation down to nbtree VACUUM. Say by >> adding it to IndexVacuumInfo. > > It has been added to that already, so it should really be as trivial as you > suggested earlier... > Right. Please find enclosed V2 also taking care of BTPageIsRecyclable() and _bt_pendingfsm_finalize(). Regards, -- Bertrand Drouvot PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com
Commits
-
Make SP-GiST redirect cleanup more aggressive.
- 05a304a85510 16.0 landed
-
Recycle deleted nbtree pages more aggressively.
- e48c817395e1 16.0 landed
-
Move heaprel struct field next to index rel field.
- a349b86603e1 16.0 landed
-
Pass down table relation into more index relation functions
- 61b313e47eb9 16.0 cited
-
Use full 64-bit XIDs in deleted nbtree pages.
- e5d8a9990304 14.0 cited