Horton

Re: more C99 cleanup

Peter Eisentraut <peter@eisentraut.org>

View thread View on postgr.es
From: Peter Eisentraut <peter@eisentraut.org>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2025-11-28T07:40:50Z
Lists: pgsql-hackers 
On 21.11.25 16:35, Tom Lane wrote:
> * In 0003, we can't be very sure what "isblank((unsigned char) c)"
> will do with non-ASCII input data, except that it could very
> easily do insane things with fragments of a multibyte character.
> I recommend keeping pg_isblank but redefining it along the lines of
> 
> 	bool
> 	pg_isblank(unsigned char c)
> 	{
> 	    return (!IS_HIGHBIT_SET(c) && isblank(c));
> 	}
> 
> to ensure the previous treatment of non-ASCII data.
> (It could be made static in hba.c, perhaps)

Ok, done that way.

Commits

  1. Update comment related to C99

  2. Fix pg_isblank()

  3. Replace internal C function pg_hypot() by standard hypot()

  4. Remove obsolete comment

  5. Report timezone offset in pg_dump/pg_dumpall